Skip to content

doc(guide): use fresh actions/checkout version in GH actions examples#17087

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
AMDmi3:update-actions-checkout-version-in-examples
Jun 9, 2026
Merged

doc(guide): use fresh actions/checkout version in GH actions examples#17087
weihanglo merged 1 commit into
rust-lang:masterfrom
AMDmi3:update-actions-checkout-version-in-examples

Conversation

@AMDmi3

@AMDmi3 AMDmi3 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Update actions/checkout version to the actual one in examples of GitHub actions code

How to test and review this PR?

Check actual action version https://github.com/actions/checkout/tags

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

weihanglo
weihanglo approved these changes Jun 9, 2026
View reviewed changes

@weihanglo weihanglo left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just FYI. We have #16741 asking for an update. There is some open question about level of support from maintainer for these snippets. My thought on it in #16741 (comment):

IMHO we don't need to be worried about that. Incremental doc improvement is better than nothing. As maintainers we provide the snippet as-is. If contributor comes we accept. If none it falls behind.

If we are worried that we may forget the perfect solution after a simple update, then we keep the issue open.

View changes since this review

@weihanglo weihanglo added this pull request to the merge queue Jun 9, 2026
Merged via the queue into rust-lang:master with commit 3ddc827 Jun 9, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2026
@AMDmi3 AMDmi3 deleted the update-actions-checkout-version-in-examples branch June 9, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels

A-documenting-cargo-itself Area: Cargo's documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AMDmi3 @rustbot @weihanglo @epage